Merged
Conversation
PostgreSQL 12 has been unsupported for over half a year, and pgrx v0.14.0 officially dropped support for it. The other reason I propose this version bumping is that pgrx v0.12.9 failed to install pg 12 on my mac. This patch removes PG12 support from the wrappers by upgrading pgrx to v0.14.3. Some code adjustments were required due to changes introduced in the newer pgrx versions. For reference, see the following updates in pgrx: - [force using extern "C-unwind" for functions marked with `#[pg_guard]`][1] - [Made SPI query arguments type safe][2] - [Added connect_mut for data changing SPI operations][3] - [Renamed Oid::as_u32 to to_u32][4] [1] pgcentralfoundation/pgrx#2014 [2] pgcentralfoundation/pgrx#1858 [3] pgcentralfoundation/pgrx#1913 [4] pgcentralfoundation/pgrx#2011 Signed-off-by: Junwang Zhao <[email protected]>
Signed-off-by: Junwang Zhao <[email protected]>
zhjwpku
force-pushed
the
bump_pgrx_to_0.14.3
branch
from
284b80d to
250f64f
Compare
Signed-off-by: Junwang Zhao <[email protected]>
Contributor
Author
|
@burmecia can you please take a look at this PR, I checked the coverage, it seems the uncovered lines were not being executed previously either, so I don't think this should be an issue, WDYT? |
Member
|
It's very useful PR, thanks @zhjwpku 👍 ! It looks good for me and we will be doing some internal testing, don't worry about the Coverage for now. |
burmecia
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL 12 has been unsupported for over half a year, and pgrx v0.14.0 officially dropped support for it.
The other reason I propose this version bumping is that pgrx v0.12.9 failed to install pg 12 on my mac.
This patch removes PG12 support from the wrappers by upgrading pgrx to v0.14.3. Some code adjustments were required due to changes introduced in the newer pgrx versions.
For reference, see the following updates in pgrx:
#[pg_guard]